-
Notifications
You must be signed in to change notification settings - Fork 1.2k
🐛 Fix code block styling in quoted message #3130
🐛 Fix code block styling in quoted message #3130
Conversation
|
@brianlovin @mxstbr i have added screenshots of quoted message before and after changes. the current changes affecting both received and sent messages. i thought its looks good for sent messages also, but i need your opinion on this. |
|
@brianlovin @mxstbr @uberbryn if design for sent messages looks fine, i can move to ready for review |
|
Yeah, go ahead and do that - I think we'll wait for a final approve from @uberbryn and we can ship :) |
|
Text contrast is too low, otherwise good changes. If you make the contrast ratio at least 2.5 (ideally AA), we can ship it. |
|
@uberbryn currently we are using colours from theme i am thinking of using css |
|
If those are above 2.5 let's ship them; I think we'll have to do another pass down the road and potentially add some higher contrast colors below our |
|
I misread this as changing from light bg to dark bg and adding spacing. that light bg is much higher contrast, so maybe we should just make both bgs that color. (not high priority) |
|
Good point @uberbryn - since they are both in a quote reply might as well be the same color |
Status
Deploy after merge (delete what needn't be deployed)
Fixes #3098